Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinned werkzeug #40

Merged
merged 2 commits into from
Jul 26, 2022
Merged

pinned werkzeug #40

merged 2 commits into from
Jul 26, 2022
+4 −2

Conversation

DustinKLo
Copy link
Contributor

error when provisioning

Traceback (most recent call last):
  File "/export/home/hysdsops/mozart/ops/mozart/./db_create.py", line 8, in <module>
    from mozart import db
  File "/export/home/hysdsops/mozart/ops/mozart/mozart/__init__.py", line 114, in <module>
    from mozart.services.ci import services as ci_services
  File "/export/home/hysdsops/mozart/ops/mozart/mozart/services/ci.py", line 14, in <module>
    from flask_restx import Api, apidoc, Resource
  File "/export/home/hysdsops/mozart/lib/python3.9/site-packages/flask_restx/__init__.py", line 5, in <module>
    from .api import Api  # noqa
  File "/export/home/hysdsops/mozart/lib/python3.9/site-packages/flask_restx/api.py", line 50, in <module>
    from .swagger import Swagger
  File "/export/home/hysdsops/mozart/lib/python3.9/site-packages/flask_restx/swagger.py", line 18, in <module>
    from werkzeug.routing import parse_rule
ImportError: cannot import name 'parse_rule' from 'werkzeug.routing' (/export/home/hysdsops/mozart/lib/python3.9/site-packages/werkzeug/routing/__init__.py)

https://stackoverflow.com/questions/73105877/importerror-cannot-import-name-parse-rule-from-werkzeug-routing

workaround is to pin the version of werkzeug until flask-login and flaks-restx make fixes for this:
python-restx/flask-restx#460 is open for flask-restx
maxcountryman/flask-login#686 for flask-login.

mcayanan
mcayanan reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@mcayanan mcayanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to bump the version too?

mozart/setup.py

Line 12 in 842abac

version='2.0.15',

@DustinKLo DustinKLo merged commit f9b4388 into develop Jul 26, 2022
@DustinKLo DustinKLo deleted the hotfix_pin_werkzeug branch July 26, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayanan mcayanan mcayanan approved these changes

@pymonger pymonger Awaiting requested review from pymonger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DustinKLo @mcayanan